Skip to content

Support for multiple MAX!Cube LAN gateways added#13517

Merged
syssi merged 3 commits intohome-assistant:devfrom
syssi:feature/maxcube-multiple-gateways-support
Apr 19, 2018
Merged

Support for multiple MAX!Cube LAN gateways added#13517
syssi merged 3 commits intohome-assistant:devfrom
syssi:feature/maxcube-multiple-gateways-support

Conversation

@syssi
Copy link
Copy Markdown
Member

@syssi syssi commented Mar 28, 2018

Description:

It's a breaking change because of the new configuration schema!

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5078

Example entry for configuration.yaml (if applicable):

maxcube:
  gateways:
    - host: 192.168.86.133
      port: 62910
    - host: 192.168.86.52
      port: 62910

"""Representation of a MAX! Cube Binary Sensor device."""

def __init__(self, hass, name, rf_address):
def __init__(self, hass, handler, name, rf_address):
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove hass

"""MAX! Cube ClimateDevice."""

def __init__(self, hass, name, rf_address):
def __init__(self, hass, handler, name, rf_address):
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@syssi syssi merged commit 674682e into home-assistant:dev Apr 19, 2018
except timeout:
_LOGGER.error("Connection to Max!Cube could not be established")
cube = None
if DOMAIN not in config:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't happen as long as a component is not set up via netdisco discovery.

@syssi syssi mentioned this pull request Apr 19, 2018
@balloob balloob mentioned this pull request Apr 27, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants