deCONZ config entry by Kane610 · Pull Request #13402 · home-assistant/core

Kane610 · 2018-03-22T22:44:58Z

Description:

Basic config entry support for deCONZ component

Checklist:

The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass

houndci-bot · 2018-03-22T22:45:04Z

+        errors = {}
+
+        if user_input is not None:
+            api_key = await async_get_api_key(self.hass.loop, **self.deconz_config)


line too long (83 > 79 characters)

balloob · 2018-03-23T06:07:59Z

+    return False
+
+
+async def async_unload_entry(hass, entry):


Remove this. We don't support unloading platforms yet and so you are not removing all the entities that this config entry has created.

balloob · 2018-03-23T06:08:14Z

@@ -186,3 +187,92 @@ async def async_configuration_callback(data):
        entity_picture="/static/images/logo_deconz.jpeg",


Please remove all the configurator code.

Is it ok that I do this when I've migrated the discovery part?

balloob · 2018-03-23T06:08:37Z

All config flows will need 100% test coverage.

balloob · 2018-03-23T06:09:18Z

+
+async def async_setup_entry(hass, entry):
+    """Set up a bridge for a config entry."""
+    result = await async_setup_deconz(hass, None, entry.data)


What if a user has a host configured and has a config entry for the same host?

Of course, I will make sure to check in both setups as well.

balloob · 2018-03-23T06:10:02Z

+        """Handle a flow start."""
+        from pydeconz.utils import async_discovery
+
+        if DOMAIN in self.hass.data:


So you cannot create a config entry if you have one configured, but you will be able to configure a host after you have created a config entry?

If there is an instance of deconz running, the config flow won't run. What do you mean by "but you will be able to configure a host after you have created a config entry"?

Kane610 · 2018-03-23T06:50:29Z

Then I can start learning how to write tests 👍
@balloob 100% test coverage of the config flow or component?

balloob · 2018-03-23T17:03:13Z

100% of the config flow.

balloob · 2018-03-23T17:03:49Z

See #13034 for inspiration

Kane610 · 2018-03-23T17:44:15Z

What is the quickest way to run only my tests?

balloob · 2018-03-23T18:40:52Z

pip3 install pytest
py.test test/components/test_deconz.py

houndci-bot · 2018-03-25T22:50:32Z

+    result['data_schema']({'host': '1.2.3.4'})
+    result['data_schema']({'host': '5.6.7.8'})
+
+


blank line at end of file

houndci-bot · 2018-03-25T22:50:32Z

+
+import homeassistant.components.deconz as deconz
+
+from tests.common import MockConfigEntry, mock_coro


'tests.common.MockConfigEntry' imported but unused
'tests.common.mock_coro' imported but unused

houndci-bot · 2018-03-25T22:50:32Z

@@ -0,0 +1,90 @@
+"""Tests for deCONZ config flow."""
+import asyncio
+from unittest.mock import Mock, patch


'unittest.mock.Mock' imported but unused
'unittest.mock.patch' imported but unused

houndci-bot · 2018-03-25T22:50:32Z

@@ -0,0 +1,90 @@
+"""Tests for deCONZ config flow."""
+import asyncio


'asyncio' imported but unused

Add pydeconz to list of test components

Kane610 · 2018-03-27T16:09:55Z

@balloob what do you think. Is this enough for a first iteration of configuration entries? I'm ready to start working on discovery and other parts when your PR has been merged 👍🏻

balloob · 2018-03-30T01:15:32Z


 async def async_setup(hass, config):
    """Set up services and configuration for deCONZ component."""
+    if DOMAIN in hass.data:


This will never happen. Home Assistant already takes care of this.

balloob · 2018-03-30T03:15:05Z

This looks good! Ok to merge after that one check has been removed.

Kane610 added 7 commits March 22, 2018 22:25

Try config entries

17c685f

Testing

cecd17b

Working flow

929450c

Config entry text strings

872e268

Removed manual inputs for config flow

d9d9824

Support unloading of config entry

444ad17

Bump requirement to v33

078f1e6

Kane610 requested review from a team and andrey-git as code owners March 22, 2018 22:44

homeassistant added integration: deconz core cla-signed labels Mar 22, 2018

houndci-bot reviewed Mar 22, 2018

View reviewed changes

Fix comments from test

5b20e5e

balloob reviewed Mar 23, 2018

View reviewed changes

Kane610 added 2 commits March 24, 2018 08:12

Make sure that only one deCONZ instance can be set up

ed1aad5

Hass doesn't support unloading platforms yet

f4e08c5

homeassistant added the cla-signed label Mar 24, 2018

Modify get_api_key to be testable

b6f88d8

houndci-bot reviewed Mar 25, 2018

View reviewed changes

Fix hound comments

b152fb0

Kane610 added 3 commits March 26, 2018 20:31

Add test dependency

f6e9804

Add test for no key

010ebe9

Bump requirement to v35

6ee7037

Add pydeconz to list of test components

Danielhiversen added the cla-recheck label Mar 27, 2018

homeassistant added cla-signed and removed cla-recheck labels Mar 27, 2018

balloob reviewed Mar 30, 2018

View reviewed changes

Don't have a check in async_setup that domain exists in hass.data

030e78e

homeassistant added the cla-signed label Mar 30, 2018

balloob merged commit 931bcee into home-assistant:dev Mar 30, 2018

balloob mentioned this pull request Apr 13, 2018

0.67.0 #13856

Merged

home-assistant locked and limited conversation to collaborators Jul 26, 2018

Kane610 deleted the deconz_config_entry branch July 29, 2019 17:50

		@@ -186,3 +187,92 @@ async def async_configuration_callback(data):
		entity_picture="/static/images/logo_deconz.jpeg",

		result['data_schema']({'host': '1.2.3.4'})
		result['data_schema']({'host': '5.6.7.8'})


		import homeassistant.components.deconz as deconz

		from tests.common import MockConfigEntry, mock_coro

		@@ -0,0 +1,90 @@
		"""Tests for deCONZ config flow."""
		import asyncio

Uh oh!

Conversation

Kane610 commented Mar 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

Checklist:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

balloob commented Mar 23, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kane610 commented Mar 23, 2018

Uh oh!

balloob commented Mar 23, 2018

Uh oh!

balloob commented Mar 23, 2018

Uh oh!

Kane610 commented Mar 23, 2018

Uh oh!

balloob commented Mar 23, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kane610 commented Mar 27, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

balloob commented Mar 30, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Kane610 commented Mar 22, 2018 •

edited

Loading