Hue: Use the currently active color mode #13376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlove
force-pushed
the
hue-return-appropriate-color
branch
from
99ecba5 to
7108746
Compare
balloob
approved these changes
Mar 23, 2018
OttoWinter
reviewed
Mar 23, 2018
| @@ -22,6 +22,7 @@ Icon | |||
|
|
|||
| # pytest | |||
| .pytest_cache | |||
| .cache | |||
There was a problem hiding this comment.
You're using an old version of pytest. Since 3.4.0 pytest will create the cache directory in .pytest_cache. See #13308 :)
(I think we can still leave it there for users with old pytest versions)
There was a problem hiding this comment.
Aah, I was already noticing that dir and was like: where did it come from.
There was a problem hiding this comment.
Ah, good call! In any case I'm sure ignoring .cache doesn't hurt.
Merged
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates hue to only report the color from the active color mode. I've noticed that currently when lights are in color temperature mode, the bulbs icons on the frontend are shown with a stale RGB color. I think this was a side-effect of the aiohue conversion.
I also noticed when writing the tests that we're not rounding float hue/sat values that are returned as attributes. I've included a fix here for that as well since it affects the tests.
Checklist:
tox. Your PR cannot be merged unless tests pass