Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pytest to 3.4.2 #13169

Merged
merged 2 commits into from
Mar 13, 2018
Merged

Upgrade pytest to 3.4.2 #13169

merged 2 commits into from
Mar 13, 2018

Conversation

OttoWinter
Copy link
Member

@OttoWinter OttoWinter commented Mar 13, 2018

Description:

Upgrade pytest: Changelog

Includes a memory leak fix that I noticed before but never investigated:

Fix memory leak where objects returned by fixtures were never destructed by the garbage collector.

Though I didn't notice any issues, pytest-sugar has a new version 0.9.1 that supposedly fixes pytest 3.4 compatability: https://github.com/Frozenball/pytest-sugar/blob/master/CHANGES.rst

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@homeassistant homeassistant added cla-signed small-pr PRs with less than 30 lines. labels Mar 13, 2018
@balloob balloob merged commit 4c9e7c2 into home-assistant:dev Mar 13, 2018
@OttoWinter OttoWinter deleted the upgrade-pytest branch March 16, 2018 11:32
engrbm87 pushed a commit to engrbm87/home-assistant-core that referenced this pull request Mar 20, 2018
* Upgrade pytest to 3.4.2

* Upgrade pytest-sugar to 0.9.1
@balloob balloob mentioned this pull request Mar 30, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants