Fix two strings for the Generic hygrostat UI #131185
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'min_cycle_duration' key shown when setting up a Generic hygrostat contains the words "in the humidifier option" which makes no sense anymore in the UI context. So these words can be dropped, making this explanation exactly identical to the same key in the Generic thermostat. In addition there is an "s" missing in the main description here.
home-assistant
bot
added
bugfix
cla-signed
integration: generic_hygrostat
small-pr
|
Hey there @Shulyaka, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
jbouwh
reviewed
Nov 21, 2024
Co-authored-by: Jan Bouwhuis <[email protected]>
Anything the user creates should use "Create …", not "Add …". The description we're addressing in the fix already has this correct. This commit adds the fix for the title. Makes it consistent with the majority of Helpers, rest needs to be addressed in separate PRs.
jbouwh
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'min_cycle_duration' key shown when setting up a Generic hygrostat contains the words "in the humidifier option" which makes no sense anymore in the UI context:
So these words can be dropped, making this explanation exactly identical to the same key in the Generic thermostat:
core/homeassistant/components/generic_thermostat/strings.json
Line 21 in 23acc31
In addition there is an "s" missing in the main description here.
Proposed change
Drop the words "in the humidifier option".
Add the missing "s" in the headline.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: