Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to pass integration domain to report_usage #130705

Merged
merged 18 commits into from
Nov 21, 2024
Merged

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Nov 15, 2024

Proposed change

Sometimes it's hard to know if the code is going to trace back to the integration.
As I was working on #130567, I realised that it always reports as "core" even though we know the offending integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@epenet epenet marked this pull request as ready for review November 18, 2024 06:46
@epenet epenet requested a review from a team as a code owner November 18, 2024 06:46
@epenet epenet marked this pull request as draft November 18, 2024 07:35
@epenet epenet marked this pull request as ready for review November 21, 2024 08:08
@bdraco
Copy link
Member

bdraco commented Nov 21, 2024

That group test is flakey. I restarted the failed CI runners so we can get a clean coverage report

@epenet
Copy link
Contributor Author

epenet commented Nov 21, 2024

That group test is flakey. I restarted the failed CI runners so we can get a clean coverage report

Coverage OK now...

codecov/patch — 100.00% of diff hit (target 80.69%)
codecov/patch/required — Coverage not affected when comparing 98ec039...f8e5d51
codecov/project — 80.70% (+0.00%) compared to 98ec039
codecov/project/required — 97.99% (+0.03%) compared to 98ec039

@epenet epenet merged commit 9add3a6 into dev Nov 21, 2024
64 checks passed
@epenet epenet deleted the epenet-20241115-1516 branch November 21, 2024 15:01
@epenet
Copy link
Contributor Author

epenet commented Nov 21, 2024

Thanks @bdraco 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants