Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use f-strings in go2rtc code and test and do not use abbreviation #130158

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Use f-strings in go2rtc code and test and do not use abbreviation #130158

merged 3 commits into from
Nov 8, 2024

Conversation

jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Nov 8, 2024

Proposed change

SSIA. Late review on #130139

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@jbouwh jbouwh requested a review from a team as a code owner November 8, 2024 18:27
@home-assistant
Copy link

home-assistant bot commented Nov 8, 2024

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (go2rtc) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of go2rtc can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign go2rtc Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@jbouwh jbouwh mentioned this pull request Nov 8, 2024
Merged
19 tasks
@jbouwh jbouwh changed the title Use f-strings in go2rtc code and test Use f-strings in go2rtc code and test and do not use abbreviation Nov 8, 2024
frenck
frenck approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jbouwh 👍

../Frenck

@frenck frenck merged commit c97cc34 into dev Nov 8, 2024
32 checks passed
@frenck frenck deleted the go2rtc-fstrings branch November 8, 2024 19:16
MartinHjelmare
MartinHjelmare reviewed Nov 8, 2024
View reviewed changes
homeassistant/components/go2rtc/__init__.py
@@ -244,21 +244,21 @@ async def async_handle_async_webrtc_offer(

if self._data.managed:
# HA manages the go2rtc instance
stream_org_name = camera.entity_id + "_orginal"
stream_original_name = f"{camera.entity_id}_orginal"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

original

tests/components/go2rtc/test_init.py
@@ -313,7 +313,7 @@ async def test_setup_managed(
camera = init_test_integration

entity_id = camera.entity_id
stream_name_orginal = camera.entity_id + "_orginal"
stream_name_orginal = f"{camera.entity_id}_orginal"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

original on both sides

@jbouwh jbouwh mentioned this pull request Nov 8, 2024
Merged
19 tasks
@jbouwh
Copy link
Contributor Author

jbouwh commented Nov 8, 2024

#130165 Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2024
@frenck frenck added this to the 2024.11.2 milestone Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare left review comments

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed code-quality has-tests integration: go2rtc Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2024.11.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jbouwh @frenck @MartinHjelmare