Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webrtc use RTCIceCandidateInit messages with frontend #129879

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from

Conversation

sdb9696
Copy link
Contributor

@sdb9696 sdb9696 commented Nov 5, 2024

Proposed change

Pass the RTCIceCandidateInit message between the frontend and backend to allow setting the sdpMid and sdpMLineIndex values.

https://www.w3.org/TR/webrtc/#dom-rtcicecandidateinit

frontend PR

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Nov 5, 2024

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (camera) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of camera can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign camera Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

homeassistant/package_constraints.txt Outdated Show resolved Hide resolved
homeassistant/components/camera/webrtc.py Outdated Show resolved Hide resolved
homeassistant/components/go2rtc/__init__.py Outdated Show resolved Hide resolved
@sdb9696 sdb9696 changed the title Add sdp m line index to WebRtc Ice Candidates Webrtc use RTCIceCandidateInit messages with frontend Nov 19, 2024
@sdb9696 sdb9696 marked this pull request as ready for review November 19, 2024 10:08
@sdb9696 sdb9696 requested a review from a team as a code owner November 19, 2024 10:08
homeassistant/components/camera/webrtc.py Outdated Show resolved Hide resolved
homeassistant/components/camera/webrtc.py Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft November 20, 2024 14:53
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@sdb9696 sdb9696 marked this pull request as ready for review November 20, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants