Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WS handler to generate encryption key for cloud backup #129771

Closed
wants to merge 2 commits into from

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Nov 4, 2024

Proposed change

Adds a WS handler to create and store a string that can be used for encrypting cloud backups.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Nov 4, 2024

Hey there @home-assistant/cloud, mind taking a look at this pull request as it has been labeled with an integration (cloud) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of cloud can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign cloud Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@MartinHjelmare
Copy link
Member

I'm assuming this needs a frontend change. If not, we can merge.

@MartinHjelmare MartinHjelmare marked this pull request as draft November 11, 2024 08:45
@emontnemery emontnemery mentioned this pull request Nov 11, 2024
19 tasks
@emontnemery emontnemery changed the base branch from dev to allthebackupchanges November 13, 2024 16:47
@MartinHjelmare
Copy link
Member

We should rebase this to allthebackupchanges branch.

@MartinHjelmare
Copy link
Member

Since we're using a feature branch we don't need to wait for frontend.

@emontnemery
Copy link
Contributor

There's some ongoing discussion about how the cloud encryption should work, we should not merge this PR until that's been settled.

@edenhaus
Copy link
Contributor

Closing it as we internally discussed that the password encryption is enough. No need for an additional cloud key

@edenhaus edenhaus closed this Nov 19, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants