Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pylutron to 0.2.16 #129653

Merged
merged 9 commits into from
Nov 5, 2024
Merged

Update pylutron to 0.2.16 #129653

merged 9 commits into from
Nov 5, 2024

Conversation

kingal123
Copy link
Contributor

@kingal123 kingal123 commented Nov 1, 2024

Proposed change

https://github.com/thecynic/pylutron/releases/tag/0.2.15
https://github.com/thecynic/pylutron/releases/tag/0.2.16
thecynic/pylutron@0.2.15...0.2.16

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-needed integration: lutron small-pr PRs with less than 30 lines. labels Nov 1, 2024
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kingal123

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft November 1, 2024 20:46
@home-assistant
Copy link

home-assistant bot commented Nov 1, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link

home-assistant bot commented Nov 1, 2024

Hey there @cdheiser, @wilburCforce, mind taking a look at this pull request as it has been labeled with an integration (lutron) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of lutron can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign lutron Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@cdheiser
Copy link
Contributor

cdheiser commented Nov 3, 2024

@kingal123 can you either stop syncing your branch or re-submitt this on a branch dedicated to this PR so you stop generating updates every few hours?

@kingal123
Copy link
Contributor Author

@kingal123 can you either stop syncing your branch or re-submitt this on a branch dedicated to this PR so you stop generating updates every few hours?

Apologies @cdheiser will leave it alone now pending review. Appreciate your help cheers

@epenet
Copy link
Contributor

epenet commented Nov 4, 2024

CI failure should be unrelated (see #129758)
Merged dev to re-trigger CI and confirm.

Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 👍

@home-assistant home-assistant bot marked this pull request as draft November 4, 2024 14:21
@kingal123 kingal123 marked this pull request as ready for review November 5, 2024 20:41
@home-assistant home-assistant bot requested a review from epenet November 5, 2024 20:41
@epenet epenet added this to the 2024.11.0 milestone Nov 5, 2024
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Could/should this be in 2024.11?

@frenck frenck merged commit 64e84e2 into home-assistant:dev Nov 5, 2024
46 checks passed
frenck pushed a commit that referenced this pull request Nov 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lutron Integration missing Palladiom Keypad DeviceType
4 participants