Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add musicassistant integration #128919

Merged
merged 58 commits into from
Oct 30, 2024
Merged

Add musicassistant integration #128919

merged 58 commits into from
Oct 30, 2024

Conversation

jozefKruszynski
Copy link
Contributor

@jozefKruszynski jozefKruszynski commented Oct 21, 2024

Proposed change

This is the first (base) PR to bring the Music Assistant integration into HA Core.

Type of change

This is the first PR to bring the Music Assistant integration into HA Core, currently it exists as a custom HACS integration, and we want to move into core to bring the experience to a larger audience and to be better integrated in general.

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

homeassistant/components/music_assistant/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/music_assistant/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/music_assistant/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/music_assistant/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/music_assistant/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/music_assistant/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/music_assistant/config_flow.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft October 21, 2024 19:15
homeassistant/components/music_assistant/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/music_assistant/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/music_assistant/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/music_assistant/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/music_assistant/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/music_assistant/media_player.py Outdated Show resolved Hide resolved
homeassistant/components/music_assistant/media_player.py Outdated Show resolved Hide resolved
homeassistant/components/music_assistant/media_player.py Outdated Show resolved Hide resolved
homeassistant/components/music_assistant/media_player.py Outdated Show resolved Hide resolved
homeassistant/components/music_assistant/media_player.py Outdated Show resolved Hide resolved
@jozefKruszynski jozefKruszynski marked this pull request as ready for review October 27, 2024 21:14
@home-assistant home-assistant bot requested a review from joostlek October 27, 2024 21:14
homeassistant/components/music_assistant/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/music_assistant/entity.py Outdated Show resolved Hide resolved
homeassistant/components/music_assistant/media_player.py Outdated Show resolved Hide resolved
homeassistant/components/music_assistant/media_player.py Outdated Show resolved Hide resolved
homeassistant/components/music_assistant/media_player.py Outdated Show resolved Hide resolved
homeassistant/components/music_assistant/media_player.py Outdated Show resolved Hide resolved
homeassistant/components/music_assistant/media_player.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft October 28, 2024 12:37
homeassistant/components/music_assistant/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/music_assistant/media_player.py Outdated Show resolved Hide resolved
homeassistant/components/music_assistant/strings.json Outdated Show resolved Hide resolved
homeassistant/components/music_assistant/strings.json Outdated Show resolved Hide resolved
tests/components/music_assistant/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/music_assistant/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/music_assistant/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/music_assistant/test_config_flow.py Outdated Show resolved Hide resolved
@jozefKruszynski jozefKruszynski marked this pull request as ready for review October 29, 2024 21:59
@home-assistant home-assistant bot requested a review from joostlek October 29, 2024 22:00
@marcelveldt marcelveldt changed the base branch from add-music-assistant-integration to dev October 30, 2024 13:50
@joostlek joostlek merged commit 568bdef into home-assistant:dev Oct 30, 2024
44 of 46 checks passed
@epenet
Copy link
Contributor

epenet commented Oct 30, 2024

Small note: the coverage for config_flow.py doesn't appear to be at 100%

@joostlek
Copy link
Member

Which one are we missing?

@epenet
Copy link
Contributor

epenet commented Oct 30, 2024

@joostlek
Copy link
Member

Oh that's a good catch. I will update

@jozefKruszynski
Copy link
Contributor Author

Ah yes, I have mocked that the whole time due to socket.socket issues

@epenet
Copy link
Contributor

epenet commented Oct 30, 2024

Ah yes, I have mocked that the whole time due to socket.socket issues

You should be able to mock the client creation and set the property on the mocked client, instead of patching the function

@joostlek
Copy link
Member

Thanks for staying sharp @epenet!

@jozefKruszynski
Copy link
Contributor Author

Ah yes, I have mocked that the whole time due to socket.socket issues

You should be able to mock the client creation and set the property on the mocked client, instead of patching the function

Sounds far more sensible

@home-assistant
Copy link

Hey there @music-assistant, mind taking a look at this pull request as it has been labeled with an integration (music_assistant) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of music_assistant can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign music_assistant Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

marcelveldt added a commit that referenced this pull request Oct 31, 2024
MartinHjelmare pushed a commit that referenced this pull request Oct 31, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants