-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add musicassistant integration #128919
Add musicassistant integration #128919
Conversation
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Small note: the coverage for config_flow.py doesn't appear to be at 100% |
Which one are we missing? |
|
Oh that's a good catch. I will update |
Ah yes, I have mocked that the whole time due to |
You should be able to mock the client creation and set the property on the mocked client, instead of patching the function |
Thanks for staying sharp @epenet! |
Sounds far more sensible |
Hey there @music-assistant, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
This reverts commit 568bdef.
Proposed change
This is the first (base) PR to bring the Music Assistant integration into HA Core.
Type of change
This is the first PR to bring the Music Assistant integration into HA Core, currently it exists as a custom HACS integration, and we want to move into core to bring the experience to a larger audience and to be better integrated in general.
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: