Handle Hue errors better

[balloob]

Description:

If a user has 2 networks behind the same IP with both a Hue hub, Hue component would fail to setup.

What would happen is that Home Assistant would get the IP address from the cloud discovery and try to connect. This would raise an OSError and we only handled ConnectionRefusedError. I've also added a generic exception handler to make sure we don't disturb the setup process of other hubs.

Example entry for configuration.yaml (if applicable):

hue:

[MartinHjelmare]

ConnectionRefusedError is a subclass of OSError.

[balloob]

Oh.

Well good thing that I am going to throw it all away when we migrate to aiohue #12830

[balloob]

I tested it locally before committing but only tested

>>> isinstance(ConnectionRefusedError, OSError)
False

But classes are of type Type.

Instantiating did the trick:

>>> isinstance(ConnectionRefusedError(), OSError)
True

[robertw]

After recent update error still there fyi

18-03-03 07:34:59 ERROR (SyncWorker_0) [homeassistant.components.hue] Unknown error connecting with Hue bridge at 192.168.1.87
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/homeassistant/components/hue.py", line 194, in setup
    config_file_path=self.hass.config.path(self.filename))
  File "/usr/lib/python3.6/site-packages/phue.py", line 629, in __init__
    self.connect()
  File "/usr/lib/python3.6/site-packages/phue.py", line 752, in connect
    self.register_app()
  File "/usr/lib/python3.6/site-packages/phue.py", line 706, in register_app
    response = self.request('POST', '/api', registration_request)
  File "/usr/lib/python3.6/site-packages/phue.py", line 667, in request
    return json.loads(response.decode('utf-8'))
  File "/usr/lib/python3.6/json/__init__.py", line 354, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.6/json/decoder.py", line 339, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.6/json/decoder.py", line 357, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
2018-03-03 07:35:00 ERROR (MainThread) [homeassistant.components.light] Error while setting up platform hue
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/homeassistant/helpers/entity_platform.py", line 84, in async_setup
    SLOW_SETUP_MAX_WAIT, loop=hass.loop)
  File "/usr/lib/python3.6/asyncio/tasks.py", line 358, in wait_for
    return fut.result()
  File "/usr/lib/python3.6/asyncio/futures.py", line 245, in result
    raise self._exception
  File "/usr/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/lib/python3.6/site-packages/homeassistant/components/light/hue.py", line 106, in setup_platform
    unthrottled_update_lights(hass, bridge, add_devices)
  File "/usr/lib/python3.6/site-packages/homeassistant/components/light/hue.py", line 123, in unthrottled_update_lights
    api = bridge.get_api()
  File "/usr/lib/python3.6/site-packages/homeassistant/components/hue.py", line 254, in get_api
    return self.bridge.get_api()
AttributeError: 'NoneType' object has no attribute 'get_api'

[MartinHjelmare]

We should probably return here.

[balloob]

Good point. Will include it in my #12830 branch

[balloob]

@robertw so it looks like your Philips Hue hub is not returning JSON. Could you update /usr/lib/python3.6/site-packages/phue.py and put a print(response.decode('utf-8')) before line 667

[robertw]

i would love to but i am running hass.io so i have no clue unless you can walk me through.....

[balloob]

Ah yes, that won't work :/