Fix dead Sonos web interface with some music sources#12796
Merged
balloob merged 2 commits intohome-assistant:devfrom Mar 1, 2018
Merged
Fix dead Sonos web interface with some music sources#12796balloob merged 2 commits intohome-assistant:devfrom
balloob merged 2 commits intohome-assistant:devfrom
Conversation
homeassistant
added
cla-signed
platform: media_player.sonos
small-pr
balloob
approved these changes
Mar 1, 2018
balloob
pushed a commit
that referenced
this pull request
Mar 1, 2018
* Get data from soco, not event * Patch soco.events.parse_event_xml to ignore exceptions
Merged
6 tasks
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR monkey patches SoCo to avoid its event thread dying on invalid XML that is popular with certain music services. This is a stopgap, SoCo itself has a fix that will be in its next update.
An initial commit changes the information extraction to rely less on the event and fetch the same data from SoCo objects. This makes the missing event data harmless.
Related issue (if applicable): hopefully fixes #12738
Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully.New dependencies have been added to theREQUIREMENTSvariable (example).New dependencies are only imported inside functions that use them (example).New dependencies have been added torequirements_all.txtby runningscript/gen_requirements_all.py.New files were added to.coveragerc.