Skip to content

Update samsungctl library to latest version#12769

Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom
uchagani:update-samsungtv-dependency
Feb 28, 2018
Merged

Update samsungctl library to latest version#12769
MartinHjelmare merged 2 commits intohome-assistant:devfrom
uchagani:update-samsungtv-dependency

Conversation

@uchagani
Copy link
Copy Markdown
Contributor

Description:

Updates media_player.samsungtv's dependency to latest version: samsungctl version 0.7.1

Related issue (if applicable): fixes #12760

Example entry for configuration.yaml (if applicable):

media_player:
  - platform: samsungtv
    host: 192.168.0.10

Checklist:

  • The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@Murph24
Copy link
Copy Markdown

Murph24 commented Feb 28, 2018

Thanks again @uchagani for taking a look at this. However, I think it needs to be specified like I have below, so we actually get the optional library ‘websocket-client’ installed as well. That’s key to the fix. Otherwise we’ll get the same result as before (no websocket-client library installed.)

samsungctl[websocket]==0.7.1

Not an expert on this but I think this the correct way to do it?

@uchagani
Copy link
Copy Markdown
Contributor Author

@Murph24 you're right. I tried it just now and with your updated string it downloads websocket. Updated PR to reflect it.

@Murph24
Copy link
Copy Markdown

Murph24 commented Feb 28, 2018

@uchagani awesome thanks!

@MartinHjelmare MartinHjelmare merged commit 9658f43 into home-assistant:dev Feb 28, 2018
@MartinHjelmare MartinHjelmare changed the title update samsungctl library to latest version Update samsungctl library to latest version Feb 28, 2018
@MartinHjelmare MartinHjelmare added this to the 0.64.2 milestone Feb 28, 2018
balloob pushed a commit that referenced this pull request Mar 1, 2018
* update samsungctl library to latest version

* add websocket dependency
@balloob balloob mentioned this pull request Mar 1, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
@uchagani uchagani deleted the update-samsungtv-dependency branch December 9, 2018 06:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Samsung TV component doesn't install websocket-client dependency

4 participants