Silence harmless sonos data structure warnings#12767
Merged
balloob merged 1 commit intohome-assistant:devfrom Feb 28, 2018
Merged
Silence harmless sonos data structure warnings#12767balloob merged 1 commit intohome-assistant:devfrom
balloob merged 1 commit intohome-assistant:devfrom
Conversation
homeassistant
added
cla-signed
platform: media_player.sonos
small-pr
balloob
pushed a commit
that referenced
this pull request
Mar 1, 2018
Merged
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The recent Sonos rework increased the allowed logging because it appeared that SoCo did not produce logs at that level in normal operation.
However, a frequent but harmless warning has now been reported. This PR turns the logging level back down for the module emitting that warning.
I have not yet managed to produce the warning myself so the change is untested for the time being.
Related issue (if applicable): fixes #12745
Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully.New dependencies have been added to theREQUIREMENTSvariable.New dependencies are only imported inside functions that use them.New dependencies have been added torequirements_all.txtby runningscript/gen_requirements_all.py.New files were added to.coveragerc.