Skip to content

bmw_connected_drive bugfix - updated to bimmer_connected 0.4.1#12759

Merged
balloob merged 1 commit intohome-assistant:devfrom
ChristianKuehnel:bimmerfix
Feb 28, 2018
Merged

bmw_connected_drive bugfix - updated to bimmer_connected 0.4.1#12759
balloob merged 1 commit intohome-assistant:devfrom
ChristianKuehnel:bimmerfix

Conversation

@ChristianKuehnel
Copy link
Copy Markdown
Contributor

Description:

Fixed parsing bug in bmw_connected_drive sensors in the bimmer_connected library. Now updating to new version of the library.

Related issue (if applicable): fixes #12698

Pull request in home-assistant.github.io with documentation (if applicable): N/A

Example entry for configuration.yaml (if applicable):

no changes

Checklist:

  • The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.64.2 milestone Feb 28, 2018
@balloob balloob merged commit bba1e2a into home-assistant:dev Feb 28, 2018
@balloob
Copy link
Copy Markdown
Member

balloob commented Feb 28, 2018

Thanks!

balloob pushed a commit that referenced this pull request Mar 1, 2018
@balloob balloob mentioned this pull request Mar 1, 2018
@ChristianKuehnel ChristianKuehnel deleted the bimmerfix branch March 18, 2018 09:22
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BMW Component Not Working

3 participants