Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build wheels for build dependencies [ci] #126987

Closed
wants to merge 1 commit into from
Closed

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Sep 28, 2024

Proposed change

Add an optional workflow_dispatch input to build build dependencies itself. This could help speedup some wheel builds. Made it optional since

  • not pinning an exact version risks it suddenly failing and blocking PRs / releases.
  • Taking quite some time. E.g. building cython every time can take up to 45min on some architectures.

The recommendation would to be to run that workflow from time to time, but especially before a planned update to numpy, pandas and other dependencies which currently take an especially long time to build.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@cdce8p cdce8p requested a review from a team as a code owner September 28, 2024 09:10
@home-assistant home-assistant bot added cla-signed code-quality small-pr PRs with less than 30 lines. labels Sep 28, 2024
@cdce8p cdce8p requested a review from frenck September 28, 2024 09:10
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of this one, as it would allow to trigger builds for random wheels that we publish.

../Frenck

@home-assistant home-assistant bot marked this pull request as draft October 18, 2024 15:38
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@cdce8p cdce8p closed this Nov 3, 2024
@cdce8p cdce8p deleted the wheels-for-build-deps branch November 3, 2024 21:30
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-quality small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants