Skip to content

Add Light support for Switcher Runner S11#126402

Merged
thecode merged 15 commits into
home-assistant:devfrom
YogevBokobza:switcher-add-s11-light-support
Sep 29, 2024
Merged

Add Light support for Switcher Runner S11#126402
thecode merged 15 commits into
home-assistant:devfrom
YogevBokobza:switcher-add-s11-light-support

Conversation

@YogevBokobza
Copy link
Copy Markdown
Contributor

@YogevBokobza YogevBokobza commented Sep 21, 2024

Proposed change

  • Added Light Platform for Switcher Runner S11
  • For Switcher Runner S11 as there are 2 light modules they will be shown in HA as Light1 and Light2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @thecode, mind taking a look at this pull request as it has been labeled with an integration (switcher_kis) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of switcher_kis can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign switcher_kis Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@YogevBokobza YogevBokobza marked this pull request as ready for review September 22, 2024 16:11
Comment thread homeassistant/components/switcher_kis/light.py Outdated
Comment thread homeassistant/components/switcher_kis/light.py Outdated
Comment thread homeassistant/components/switcher_kis/light.py Outdated
Comment thread homeassistant/components/switcher_kis/light.py Outdated
@home-assistant home-assistant Bot marked this pull request as draft September 22, 2024 20:37
@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@thecode
Copy link
Copy Markdown
Member

thecode commented Sep 22, 2024

Please update the PR description:

  • Remove the "Breaking change" section
  • Explain the added platform and the entities naming in the "Proposed change"
  • Add link to docs PR
  • Don't mark "The manifest file" unless you update it in the PR

@YogevBokobza
Copy link
Copy Markdown
Contributor Author

Please update the PR description:

  • Remove the "Breaking change" section
  • Explain the added platform and the entities naming in the "Proposed change"
  • Add link to docs PR
  • Don't mark "The manifest file" unless you update it in the PR
  1. Done
  2. Done
  3. How can a PR with light doc be created if this PR has not yet merged?
  4. Done

@YogevBokobza YogevBokobza force-pushed the switcher-add-s11-light-support branch from a18de1a to d00086e Compare September 22, 2024 22:05
@thecode
Copy link
Copy Markdown
Member

thecode commented Sep 22, 2024

How can a PR with light doc be created if this home-assistant/home-assistant.io#34269 has not yet merged?

Same as you did it last time, create a PR for the next branch and link the PR here.

Please void constantly force pushing the branch, there is no need to do it unless something updated on a different PR.

@YogevBokobza
Copy link
Copy Markdown
Contributor Author

How can a PR with light doc be created if this home-assistant/home-assistant.io#34269 has not yet merged?

Same as you did it last time, create a PR for the next branch and link the PR here.

Please void constantly force pushing the branch, there is no need to do it unless something updated on a different PR.

Should I create a new PR to next or use this home-assistant/home-assistant.io#34269?

@YogevBokobza YogevBokobza force-pushed the switcher-add-s11-light-support branch from 85413b2 to 776ec32 Compare September 23, 2024 15:28
@YogevBokobza YogevBokobza marked this pull request as ready for review September 23, 2024 17:51
Comment thread homeassistant/components/switcher_kis/light.py Outdated
@home-assistant home-assistant Bot marked this pull request as draft September 26, 2024 11:26
@joostlek joostlek marked this pull request as ready for review September 27, 2024 09:53
@YogevBokobza YogevBokobza force-pushed the switcher-add-s11-light-support branch from 15cbcea to f7c44f5 Compare September 27, 2024 11:15
@thecode
Copy link
Copy Markdown
Member

thecode commented Sep 27, 2024

@YogevBokobza Please avoid constantly force pushing the branch for no reason

Comment thread tests/components/switcher_kis/test_light.py Outdated
Comment thread tests/components/switcher_kis/test_light.py Outdated
@home-assistant home-assistant Bot marked this pull request as draft September 27, 2024 17:20
@YogevBokobza YogevBokobza marked this pull request as ready for review September 29, 2024 09:21
Copy link
Copy Markdown
Member

@thecode thecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @YogevBokobza 👍

@thecode thecode merged commit be11d1c into home-assistant:dev Sep 29, 2024
@YogevBokobza YogevBokobza deleted the switcher-add-s11-light-support branch September 29, 2024 10:54
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants