Skip to content

Fix fix isy994 fan detection #12595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 5 commits into from
Feb 22, 2018
Merged

Fix fix isy994 fan detection #12595

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
493c240
Fixed 3 small issues in isy994 component
OverloadUT Feb 15, 2018
b3f0d27
Fix ISY994 fan detection
OverloadUT Feb 16, 2018
d44f229
Add special-case for FanLincs so the light node is detected properly
OverloadUT Feb 22, 2018
968c3a0
Merge to update branch to upstream
OverloadUT Feb 22, 2018
6ef8be1
Re-add insteon-type filter for fans, which dropped in a merge error
OverloadUT Feb 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions homeassistant/components/isy994.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,9 @@
},
'fan': {
'uom': [],
'states': ['off', 'low', 'medium', 'high'],
'states': ['off', 'low', 'med', 'high'],
'node_def_id': ['FanLincMotor'],
'insteon_type': []
'insteon_type': ['1.46.']
},
'cover': {
'uom': ['97'],
Expand Down Expand Up @@ -173,6 +173,14 @@ def _check_for_insteon_type(hass: HomeAssistant, node,
for domain in domains:
if any([device_type.startswith(t) for t in
set(NODE_FILTERS[domain]['insteon_type'])]):

# Hacky special-case just for FanLinc, which has a light module
# as one of its nodes. Note that this special-case is not necessary
# on ISY 5.x firmware as it uses the superior NodeDefs method
if domain == 'fan' and int(node.nid[-1]) == 1:
hass.data[ISY994_NODES]['light'].append(node)
return True

hass.data[ISY994_NODES][domain].append(node)
return True

Expand Down