Avoid warnings when purging an empty database#12494
Merged
Merged
Conversation
homeassistant
added
integration: recorder
core
small-pr
Member
|
py.test -W error testfile.py |
dmulcahey
pushed a commit
to dmulcahey/home-assistant
that referenced
this pull request
Feb 19, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This hopefully addresses the SQLAlchemy warning mentioned by @balloob in #12448 (review) though I am unable to verify because I do not know how to get the warning.
Anyway, to avoid the warning about an empty
INclause, we now only add the filter for protected states when we actually have some states to protect.Checklist:
If the code does not interact with devices:
toxrun successfully.Tests have been added to verify that the new code works.