Skip to content

Fix mired range in blebox color temp mode lights#124258

Merged
joostlek merged 2 commits into
home-assistant:devfrom
swistakm:blebox/fix-mired-range-in-blebox-lights-in-color-temp-mode
Sep 6, 2024
Merged

Fix mired range in blebox color temp mode lights#124258
joostlek merged 2 commits into
home-assistant:devfrom
swistakm:blebox/fix-mired-range-in-blebox-lights-in-color-temp-mode

Conversation

@swistakm
Copy link
Copy Markdown
Contributor

Proposed change

Due to misunderstanding of the Light feature in homeassistant, the mired range for Blebox lights was set to 1-255 as blebox wlighbox devices encode color temperature as integer value in range 0-255. This as result was giving Kelvin range in the HA UI of 1,000,000K - ~4,000K. Blebox wlightbox devices that work in color mode operate typically in 2700-6500K range.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @bbx-a, mind taking a look at this pull request as it has been labeled with an integration (blebox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of blebox can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign blebox Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@swistakm swistakm changed the title fix: use default mired range in belbox lights running in color temp mode fix: use proper mired range in belbox lights running in color temp mode Aug 19, 2024
@MartinHjelmare MartinHjelmare changed the title fix: use proper mired range in belbox lights running in color temp mode Fix mired range in blebox color temp mode lights Aug 24, 2024
@joostlek joostlek added this to the 2024.9.2 milestone Sep 6, 2024
@joostlek joostlek merged commit 883e33e into home-assistant:dev Sep 6, 2024
Gigatrappeur pushed a commit to Gigatrappeur/ha-core that referenced this pull request Sep 7, 2024
* fix: use default mired range in belbox lights running in color temp mode

* fix: ruff
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants