Skip to content

Use library fork for ViCare integration #124107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinHjelmare merged 7 commits into from
Aug 19, 2024
Merged

Use library fork for ViCare integration #124107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a36ca0f
switch dependency to fork
CFenner Aug 17, 2024
3cdaec0
Update manifest.json
CFenner Aug 17, 2024
45d566b
Update requirements_all.txt
CFenner Aug 17, 2024
492fffb
Update requirements_test_all.txt
CFenner Aug 17, 2024
cb81a45
Merge branch 'dev' into neo
CFenner Aug 17, 2024
e1ed5d0
Merge branch 'dev' into neo
CFenner Aug 17, 2024
363bd4c
Merge branch 'dev' into neo
CFenner Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion homeassistant/components/vicare/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@
"documentation": "https://www.home-assistant.io/integrations/vicare",
"iot_class": "cloud_polling",
"loggers": ["PyViCare"],
"requirements": ["PyViCare==2.32.0"]
"requirements": ["PyViCare-neo==0.2.1"]
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare Aug 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're not planning to contribute back changes to upstream you should ask GitHub to disconnect your fork from its upstream. That way it's clear to the community that it's a separate project going forward.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare Aug 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a description to the PR of the due diligence that has been done to continue working with upstream project before labeling the project as unmaintained.

Copy link
Copy Markdown
Contributor Author

@CFenner CFenner Aug 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a description to the PR of the due diligence that has been done

done, I hope that is enough.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare Aug 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Copy Markdown
Contributor Author

@CFenner CFenner Aug 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original owner of the lib just responded and agreed to transfer the repo to a dedicated org where we can share the ownership.
Hope it's not a big deal to change back once the repo is transferred, release is setup and the bugfixes are cherry-picked.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare Aug 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine. You can link to this discussion thread in the future PR that changes back the library.

}
2 changes: 1 addition & 1 deletion requirements_all.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ PyTransportNSW==0.1.1
PyTurboJPEG==1.7.1

# homeassistant.components.vicare
PyViCare==2.32.0
PyViCare-neo==0.2.1

# homeassistant.components.xiaomi_aqara
PyXiaomiGateway==0.14.3
Expand Down
2 changes: 1 addition & 1 deletion requirements_test_all.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ PyTransportNSW==0.1.1
PyTurboJPEG==1.7.1

# homeassistant.components.vicare
PyViCare==2.32.0
PyViCare-neo==0.2.1

# homeassistant.components.xiaomi_aqara
PyXiaomiGateway==0.14.3
Expand Down