Fix MercedesMe - add check for unsupported features#12342
Merged
balloob merged 3 commits intohome-assistant:devfrom Feb 13, 2018
ReneNulschDE:MercedesMeV1-1
Merged
Fix MercedesMe - add check for unsupported features#12342balloob merged 3 commits intohome-assistant:devfrom ReneNulschDE:MercedesMeV1-1
balloob merged 3 commits intohome-assistant:devfrom
ReneNulschDE:MercedesMeV1-1
Conversation
| dev_id=dev_id, host_name=name, | ||
| gps=(lat, lon), attributes=attrs | ||
| ) | ||
| if device['services'].get('VEHICLE_FINDER', False): |
Member
There was a problem hiding this comment.
Make this a guard clause instead by inverting the check and continue the iteration if the check is true. Then you can outdent the following block.
balloob
pushed a commit
that referenced
this pull request
Feb 14, 2018
* Add check for unsupported features * Lint fix * change to guard clause
Merged
ghost
removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds some additional checks for available features. The feature set depends on car configuration and country.
Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests pass