Fix Report State for Alexa Brightness Controller#12318
Merged
balloob merged 2 commits intohome-assistant:devfrom Feb 12, 2018
lucasweb78:fix-alexa-brightness-controller
Merged
Fix Report State for Alexa Brightness Controller#12318balloob merged 2 commits intohome-assistant:devfrom lucasweb78:fix-alexa-brightness-controller
balloob merged 2 commits intohome-assistant:devfrom
lucasweb78:fix-alexa-brightness-controller
Conversation
houndci-bot
reviewed
Feb 11, 2018
There was a problem hiding this comment.
line too long (94 > 79 characters)
There was a problem hiding this comment.
line too long (110 > 79 characters)
lucasweb78
commented
Feb 11, 2018
Contributor
Author
There was a problem hiding this comment.
I think this was a mistake, the assert would always exit with a success if the first property was not the one being asserted. This fixes that so all properties are checked and at least one must match the assertion.
balloob
approved these changes
Feb 11, 2018
balloob
pushed a commit
that referenced
this pull request
Feb 12, 2018
* Fix Report State for Alexa Brightness Controller * Lint
Merged
balloob
pushed a commit
that referenced
this pull request
Feb 12, 2018
* Fix Report State for Alexa Brightness Controller * Lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The Report State for Alexa.BrightnessController fails because it assumes
brightnessis included in the entities properties at all times. This is not the case,brightnessis only included when the light is on.Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass