Skip to content

Protect bloomsky platform setup#12316

Merged
fabaff merged 1 commit intodevfrom
fix-bloomsky
Feb 11, 2018
Merged

Protect bloomsky platform setup#12316
fabaff merged 1 commit intodevfrom
fix-bloomsky

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Feb 11, 2018

Description:

The bloomsky component loads the platforms via discovery. When the user would add the platform config to the config, a race condition could occur, logging an error. It would still work as discovery would load the platform in the correct way later.

Related issue (if applicable): fixes #12288

@balloob balloob added this to the 0.63.1 milestone Feb 11, 2018
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐦

@fabaff fabaff merged commit 3e150bb into dev Feb 11, 2018
@fabaff fabaff deleted the fix-bloomsky branch February 11, 2018 21:49
@balloob balloob removed this from the 0.63.1 milestone Feb 12, 2018
@balloob
Copy link
Copy Markdown
Member Author

balloob commented Feb 12, 2018

I realize now that this is wrong. Reverting it 🤔

balloob added a commit that referenced this pull request Feb 12, 2018
@balloob
Copy link
Copy Markdown
Member Author

balloob commented Feb 12, 2018

The real issue is that dependencies of platforms not properly got loaded.

@balloob balloob mentioned this pull request Feb 12, 2018
balloob added a commit that referenced this pull request Feb 12, 2018
@balloob balloob mentioned this pull request Feb 22, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AttributeError: 'NoneType' object has no attribute 'devices' for Bloomsky in 0.63

3 participants