New Component: KIWI Door Lock by c7h · Pull Request #12304 · home-assistant/core

c7h · 2018-02-11T14:20:17Z

Description:

Added support for the KIWI Door lock platform (https://kiwi.ki).

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#4639

Example entry for `configuration.yaml` (if applicable):

lock:
  - platform: kiwi
    username: email@example.com
    password: supersecretpassword

Checklist:

The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

Local tests with tox run successfully. Your PR cannot be merged unless tests pass
New dependencies have been added to the REQUIREMENTS variable (example).
New dependencies are only imported inside functions that use them (example).
New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
New files were added to .coveragerc.

bugfixes improved attribute display flake8 more style adjustments

flake8

homeassistant · 2018-02-11T14:20:19Z

Hi @c7h,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

houndci-bot · 2018-02-11T14:20:23Z

blank line at end of file

houndci-bot · 2018-02-11T14:20:23Z

blank line contains whitespace

see PR home-assistant/core#12304

c7h · 2018-02-11T18:06:52Z

looks like travis run into a timeout - that's why the build failed:

Traceback (most recent call last):
  File "/home/travis/build/home-assistant/home-assistant/tests/components/sensor/test_dsmr.py", line 85, in test_default_setup
    assert power_consumption.state == '0.0'
AssertionError: assert 'unknown' == '0.0'
 +  where 'unknown' = <state sensor.power_consumption=unknown; friendly_name=Power Consumption, icon=mdi:flash @ 2018-02-11T17:27:53.351542+00:00>.state

can someone please re-run this build?

reordered imports and flake8 attempt to pelase a very picky linter also pleasing pylint now :)

c7h · 2018-02-12T10:49:16Z

@andrey-git can you re-run job https://travis-ci.org/home-assistant/home-assistant/jobs/340244800 please? It timed out and blocked the build. Cheers

thijsdejong · 2018-02-12T11:11:32Z

You can close and then re-open the PR to rerun the build.

fabaff · 2018-02-15T18:29:58Z

+import requests
+
+import voluptuous as vol
+


Please keep the import grouped.

fabaff · 2018-02-15T18:30:04Z

+
+_LOGGER = logging.getLogger(__name__)
+
+ATTR_TYPE = "hardware type"


Set it to ATTR_TYPE = 'hardware_type'.

fabaff · 2018-02-15T18:32:37Z

+from homeassistant.const import (
+    CONF_PASSWORD, CONF_USERNAME, ATTR_ID, ATTR_LONGITUDE, ATTR_LATITUDE)
+
+REQUIREMENTS = ['python-dateutil==2.6.1']


Use homeassistant.util.dt if you have to deal with time/date objects.

ah okay - didn't know about that - that would be nice because It would eliminate the REQUIREMENTS

fabaff · 2018-02-15T18:33:21Z

+
+ATTR_TYPE = "hardware type"
+ATTR_PERMISSION = 'permission'
+ATTR_CAN_INVITE = "can invite others"


ATTR_CAN_INVITE = 'can_invite_others'

fabaff · 2018-02-15T18:38:40Z

+    add_devices([KiwiLock(lock, kiwi) for lock in kiwi.get_locks()], True)
+
+
+class KiwiClient:


This code should be placed in a module which can be installed from PyPI. This way other people can re-use it and we don't need to ship device-specific code with Home Assistant.

That would be ideal but If you look at it - it doesn't do much but and in my opinion it's not worth creating a PyPI package for it. I reference to the locktrion lock which does not use a site package as well. I'm pro moving to a PyPI once functionality grows.

https://home-assistant.io/developers/code_review_platform/

See 6.1 and the note on top.

OK I'll create a pip. Just give me some days to finish my vacation 🏄

c7h · 2018-02-28T10:27:31Z

@fabaff is there anything else?

balloob · 2018-03-01T01:31:10Z

    homeassistant/components/lock/nello.py
    homeassistant/components/lock/nuki.py
    homeassistant/components/lock/sesame.py
+    homeassistant/components/lock/kiwi.py


balloob

Please create a standalone Python package that contains the logic.

balloob · 2018-05-02T17:46:29Z

This PR seems to have gone stale. Closing it. You can reopen it when you're ready to finish it.

c7h added 2 commits February 11, 2018 14:49

initial commit for kiwi door locks

6a67344

bugfixes improved attribute display flake8 more style adjustments

added session handling

46c1339

flake8

c7h requested a review from andrey-git as a code owner February 11, 2018 14:20

homeassistant added cla-needed new-platform platform: lock.kiwi labels Feb 11, 2018

houndci-bot reviewed Feb 11, 2018

View reviewed changes

homeassistant added cla-signed and removed cla-needed labels Feb 11, 2018

c7h added a commit to c7h/home-assistant.github.io that referenced this pull request Feb 11, 2018

Create component description for KIWI Platform

a00662f

see PR home-assistant/core#12304

c7h mentioned this pull request Feb 11, 2018

Documentation for KIWI lock component home-assistant/home-assistant.io#4639

Closed

2 tasks

c7h changed the title ~~[WIP] New Component: KIWI Door Lock~~ New Component: KIWI Door Lock Feb 11, 2018

homeassistant added the cla-signed label Feb 11, 2018

sindrehan mentioned this pull request Feb 11, 2018

Implement HoundCI for linting PRs vortexntnu/rov-control#55

Open

added requirements_all

6db0fb2

reordered imports and flake8 attempt to pelase a very picky linter also pleasing pylint now :)

c7h force-pushed the feature/lock_kiwi branch from 051447a to 6db0fb2 Compare February 11, 2018 18:25

homeassistant added the cla-signed label Feb 11, 2018

re-try the build

50f39ed

c7h closed this Feb 12, 2018

c7h reopened this Feb 12, 2018

added kiwi.py to .coveragerc

f68345f

homeassistant added the cla-signed label Feb 13, 2018

c7h closed this Feb 13, 2018

c7h reopened this Feb 13, 2018

fabaff reviewed Feb 15, 2018

View reviewed changes

reorganized datetime handling and attribute naming

cb4f3c3

homeassistant added the cla-signed label Feb 18, 2018

balloob reviewed Mar 1, 2018

View reviewed changes

balloob requested changes Mar 1, 2018

View reviewed changes

balloob closed this May 2, 2018

fabaff mentioned this pull request May 16, 2018

Add support for KIWI Door Locks #14485

Merged

7 tasks

home-assistant locked and limited conversation to collaborators Sep 5, 2018

ghost added integration: kiwi and removed platform: lock.kiwi labels Mar 21, 2019


		_LOGGER = logging.getLogger(__name__)

		ATTR_TYPE = "hardware type"

		add_devices([KiwiLock(lock, kiwi) for lock in kiwi.get_locks()], True)


		class KiwiClient:

Uh oh!

Conversation

c7h commented Feb 11, 2018 • edited by fabaff Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

Uh oh!

homeassistant commented Feb 11, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

c7h commented Feb 11, 2018

Uh oh!

c7h commented Feb 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thijsdejong commented Feb 12, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

c7h commented Feb 28, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

balloob left a comment

Choose a reason for hiding this comment

Uh oh!

balloob commented May 2, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

c7h commented Feb 11, 2018 •

edited by fabaff

Loading

Example entry for `configuration.yaml` (if applicable):

c7h commented Feb 12, 2018 •

edited

Loading