Fix test fixture encoding#12296
Merged
balloob merged 1 commit intohome-assistant:devfrom Feb 11, 2018
Merged
Conversation
balloob
approved these changes
Feb 11, 2018
Member
|
pathlib is just a different way of doing the same thing. People have their preference. And no, there is no reason to migrate all our usages to pathlib 😉 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
For the past week, I've constantly been getting errors when running the py.test tests from within PyCharm and ignored them since they had nothing to do with my code. Example:
Now I finally took some time to dig into this and manually setting the encoding in
load_fixtureseems to fix the problem. This shouldn't cause any issues on other systems since all fixtures are encoded withutf-8anyway.Side note: Is there any reason we're not using pathlib? I've used it in my own scripts for months now and it's so much easier to use (and probably safer) than doing
os.path.join.Checklist:
toxrun successfully. Your PR cannot be merged unless tests pass