Skip to content

Fix Panel_IFrame - FTP URL not allowed in 0.63#12295

Merged
balloob merged 1 commit intohome-assistant:devfrom
ReneNulschDE:Fix-Panel-IFrame
Feb 11, 2018
Merged

Fix Panel_IFrame - FTP URL not allowed in 0.63#12295
balloob merged 1 commit intohome-assistant:devfrom
ReneNulschDE:Fix-Panel-IFrame

Conversation

@ReneNulschDE
Copy link
Copy Markdown
Contributor

Description:

FTP links are not allowed in 0.63. Changed code back to vol.url() test.
Additional test added.

Related issue (if applicable): fixes #12286

Example entry for configuration.yaml (if applicable):

panel_iframe:
  router:
    title: 'Router'
    url: 'ftp://192.168.1.1'

Checklist:

  • The code change is tested and works locally.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@ReneNulschDE ReneNulschDE requested a review from a team as a code owner February 11, 2018 10:17
@balloob balloob merged commit 64c5d26 into home-assistant:dev Feb 11, 2018
@ReneNulschDE ReneNulschDE deleted the Fix-Panel-IFrame branch February 11, 2018 17:28
@balloob balloob mentioned this pull request Feb 22, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Weblinks 'Failed config' in 0.63

3 participants