Force LF line endings for Windows #12266
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| # Ensure Docker script files uses LF to support Docker for Windows. | ||
| # Ensure "git config --global core.autocrlf input" before you clone | ||
| setup_docker_prereqs text eol=lf | ||
| /virtualization/Docker/scripts/* text eol=lf | ||
| /script/* text eol=lf | ||
| *.sh text eol=lf | ||
|
Member
There was a problem hiding this comment. There are no shell or Python scripts in the root? or does this also match
Member
Author
There was a problem hiding this comment.
|
||
| *.py text eol=lf whitespace=error | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we just force this for all files instead of pick and choose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is indeedwhat github recommends, but then you should EXCLUDE all binary files
Grepping through our repo, it seems that this should work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we even have ico, jpg, png or zip files in our repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's follow the GitHub recommendations including
* text=autoThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So could we do
* text=lf?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it must be
* text eol=lfaccording to git-scmIt controls different parts:
*: Applied to all files, hence the need to remove it on binary files, like images&zip latertext: Ensure LF in the repoeol=lf: Attribute to ensure LF in the working directory (This should fix Windows)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So confusing. Okay, so I guess this PR is fine then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pushed the version at the top of our discussion, so read to go now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed confusing, hopefully we can change it once and just forget about it again.... it only really troubles Windows users