added more debug logging for sensor.alpha_vantage#12249
Merged
fabaff merged 4 commits intohome-assistant:devfrom Feb 8, 2018
Merged
added more debug logging for sensor.alpha_vantage#12249fabaff merged 4 commits intohome-assistant:devfrom
fabaff merged 4 commits intohome-assistant:devfrom
Conversation
arsaboo
reviewed
Feb 8, 2018
| dev.append(AlphaVantageForeignExchange(forex, conversion)) | ||
|
|
||
| add_devices(dev, True) | ||
| _LOGGER.debug('setup complated') |
arsaboo
reviewed
Feb 8, 2018
|
|
||
| def update(self): | ||
| """Get the latest data and updates the states.""" | ||
| _LOGGER.debug('requesting new data for symbol %s', self._symbol) |
Contributor
There was a problem hiding this comment.
Can you capitalize the first letter in all the comments.
1 task
OttoWinter
reviewed
Feb 8, 2018
| dev = [] | ||
| for symbol in symbols: | ||
| try: | ||
| _LOGGER.debug('Configuring timeseries for symbols: %s', |
Member
There was a problem hiding this comment.
As per the development guidelines:
Use single quotes
'for single word and"for multiple words or sentences.
fabaff
added
docs-missing
breaking-change
and removed
breaking-change
docs-missing
labels
Merged
ghost
added
integration: alpha_vantage
and removed
platform: sensor.alpha_vantage
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
I added more debug logging statements to sensor.alpha_vantage to be able to debug issues in the field.
Related issue (if applicable): N/A
Pull request in home-assistant.github.io with documentation (if applicable): N/A
Example entry for
configuration.yaml(if applicable):no changes
Checklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass