Skip to content

allow wildcards in subscription #12247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 8 commits into from
Feb 9, 2018
Merged

allow wildcards in subscription #12247

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
35fc491
allow wildcards in subscription
escoand Feb 8, 2018
8e75869
remove whitespaces
escoand Feb 8, 2018
5bbe118
make function public
escoand Feb 8, 2018
d5fe32e
also implement for mqtt_json
escoand Feb 8, 2018
b90a414
avoid mqtt-outside topic matching
escoand Feb 8, 2018
8ba8f3b
add wildcard tests
escoand Feb 9, 2018
c0c1936
add not matching wildcard tests
escoand Feb 9, 2018
0a25ac6
fix not-matching tests
escoand Feb 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions homeassistant/components/device_tracker/mqtt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,11 @@ def async_setup_scanner(hass, config, async_see, discovery_info=None):
@callback
def async_tracker_message_received(topic, payload, qos):
"""Handle received MQTT message."""
hass.async_add_job(
async_see(dev_id=dev_id_lookup[topic], location_name=payload))
for subscription in dev_id_lookup:
if mqtt._match_topic(subscription, topic):

@houndci-bot houndci-bot Feb 8, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing whitespace

hass.async_add_job(async_see(

@houndci-bot houndci-bot Feb 8, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing whitespace

dev_id=dev_id_lookup[subscription],
location_name=payload))

@houndci-bot houndci-bot Feb 8, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing whitespace


for dev_id, topic in devices.items():
dev_id_lookup[topic] = dev_id
Expand Down