Xiaomi MiIO Light: Brightness mapping improved#12203
Merged
rytilahti merged 2 commits intohome-assistant:devfrom Feb 6, 2018
Merged
Conversation
| if ATTR_BRIGHTNESS in kwargs: | ||
| brightness = kwargs[ATTR_BRIGHTNESS] | ||
| percent_brightness = int(100 * brightness / 255) | ||
| percent_brightness = int(ceil(100 * brightness / 255.0)) |
Member
There was a problem hiding this comment.
Do you need int when you have ceil?
Member
Author
There was a problem hiding this comment.
You are right. python3 returns an int. math.ceil of python2.7 returns a float.
Member
|
Looks fine to me, thanks! 👍 |
Merged
3 tasks
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xiaomi Philips Lights accepts a brightness between 1 and 100 percent. HA has a brightness range of [1,255]. In the past the HA brightness 1, 2 and 3 was mapped to 0 percent. The mapping is shifted a bit now to improve the user experience.