Add sensor platform to MadVR by iloveicedgreentea · Pull Request #121617 · home-assistant/core

iloveicedgreentea · 2024-07-09T18:11:14Z

Proposed change

This add sensors + tests and options flow for madvr

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request: Madvr-sensors home-assistant.io#33896

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

joostlek

Please revert the change in config_flow.py

home-assistant · 2024-07-09T19:00:15Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

frenck · 2024-07-09T19:26:07Z

Marked docs-missing as the linked PR belongs to a different parent PR. This PR does not have documentation.

iloveicedgreentea · 2024-07-09T20:16:38Z

Updated sensors to use enums and other classes, consolidate tests into snapshot, updated the docs PR to reference this one

home-assistant/home-assistant.io#33659

iloveicedgreentea · 2024-07-11T02:33:04Z

updated names and snapshot platform

iloveicedgreentea · 2024-07-14T19:41:04Z

@joostlek I updated the docs link btw should be good now

joostlek · 2024-07-19T10:08:26Z

This change is unrelated

its not related but makes the code a lot easier to work with

But it should go in a separate PR as its outside of the scope of the sensor platform

joostlek · 2024-07-19T10:08:43Z

  "integration_type": "device",
  "iot_class": "local_push",
-  "requirements": ["py-madvr2==1.6.27"]
+  "requirements": ["py-madvr2==1.6.28"]


Can we bump in a separate PR?

no its required to fix how one of the sensors works

No but please bump this in a PR before this PR

iloveicedgreentea · 2024-07-20T21:57:27Z

Updated doc PR: home-assistant/home-assistant.io#33896

iloveicedgreentea · 2024-07-20T22:55:34Z

Addressed comments and updated snapshots

iloveicedgreentea added 3 commits July 9, 2024 17:20

feat: add sensors

7c6a9b6

feat: add tests for sensors

9f5ae51

feat: add options flow

48e9f0d

home-assistant Bot added cla-signed has-tests integration: madvr new-platform by-code-owner Quality Scale: No score labels Jul 9, 2024

iloveicedgreentea added 2 commits July 9, 2024 18:30

feat: add tests for options flow

166e33f

fix: remove options flow

f2733b8

iloveicedgreentea marked this pull request as ready for review July 9, 2024 18:43

iloveicedgreentea mentioned this pull request Jul 9, 2024

feat: update madvr docs home-assistant/home-assistant.io#33659

Merged

8 tasks

joostlek changed the title ~~Madvr_more-entities~~ Add sensor platform to MadVR Jul 9, 2024

joostlek requested changes Jul 9, 2024

View reviewed changes

home-assistant Bot marked this pull request as draft July 9, 2024 19:00

fix: remove names and mac sensor, add incoming signal type

3f85560

frenck added the docs-missing label Jul 9, 2024

iloveicedgreentea added 2 commits July 9, 2024 20:10

feat: add enum types to supported sensors

d06b92d

fix: consolidate tests into snapshot

1ce4be6

iloveicedgreentea marked this pull request as ready for review July 9, 2024 20:18

home-assistant Bot requested a review from joostlek July 9, 2024 20:18

fix: use consts

b32b8f0

joostlek requested changes Jul 10, 2024

View reviewed changes

Comment thread homeassistant/components/madvr/strings.json Outdated

Comment thread tests/components/madvr/test_sensors.py Outdated

home-assistant Bot marked this pull request as draft July 10, 2024 09:46

fix: update names and use snapshot platform

b1ea0ff

iloveicedgreentea marked this pull request as ready for review July 11, 2024 02:33

home-assistant Bot requested a review from joostlek July 11, 2024 02:33

iloveicedgreentea added 3 commits July 11, 2024 02:38

fix: fix test name for new translations

03a68c9

fix: comment

af6984d

fix: improve sensor names

7b85ea6

joostlek requested changes Jul 20, 2024

View reviewed changes

home-assistant Bot marked this pull request as draft July 20, 2024 18:42

fix: address comments

c992610

iloveicedgreentea mentioned this pull request Jul 20, 2024

Bump py-madvr to 1.6.29 #122275

Merged

19 tasks

iloveicedgreentea added 3 commits July 20, 2024 13:13

Merge branch 'dev' into madvr_more-entities

357e2c3

feat: disable uncommon sensors by default

9fae4a3

Merge branch 'dev' into madvr_more-entities

1e945ee

iloveicedgreentea marked this pull request as ready for review July 20, 2024 21:08

home-assistant Bot requested a review from joostlek July 20, 2024 21:08

iloveicedgreentea mentioned this pull request Jul 20, 2024

Madvr-sensors home-assistant/home-assistant.io#33896

Merged

8 tasks

joostlek removed the docs-missing label Jul 20, 2024

iloveicedgreentea added 2 commits July 20, 2024 22:51

fix: update sensors

09362ff

fix: revert config_flow change

66fc43d

joostlek approved these changes Jul 21, 2024

View reviewed changes

joostlek merged commit fcca475 into home-assistant:dev Jul 21, 2024

github-actions Bot locked and limited conversation to collaborators Jul 22, 2024

Uh oh!

Conversation

iloveicedgreentea commented Jul 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Additional information

Checklist

Uh oh!

joostlek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

home-assistant Bot commented Jul 9, 2024

Uh oh!

frenck commented Jul 9, 2024

Uh oh!

iloveicedgreentea commented Jul 9, 2024

Uh oh!

Uh oh!

Uh oh!

iloveicedgreentea commented Jul 11, 2024

Uh oh!

iloveicedgreentea commented Jul 14, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iloveicedgreentea commented Jul 20, 2024

Uh oh!

iloveicedgreentea commented Jul 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

iloveicedgreentea commented Jul 9, 2024 •

edited

Loading