-
-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mac address as connection for matter device #121257
base: dev
Are you sure you want to change the base?
Add mac address as connection for matter device #121257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
38efa9c
to
11a296d
Compare
connections = { | ||
( | ||
dr.CONNECTION_NETWORK_MAC, | ||
convert_mac_address(network_interface.hardwareAddress), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to guard for invalid data here as we have seen devices in the wild with malformed data in the hardwareAddress field. So my proposal is to convert this entire block into a small helper util which guards for invalid mac addresses (or the convert_mac_address util erroring)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review.
I'll look into it shortly.
I've marked this PR, as changes are requested that need to be processed. Thanks! 👍 ../Frenck |
Proposed change
This PR adds a mac address connection for matter devices that have a mac address, so that they can be matched with existing devices in the registry.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: