Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sound modes to Bang & Olufsen devices #121209

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

mj23000
Copy link
Contributor

@mj23000 mj23000 commented Jul 4, 2024

Proposed change

Add sound mode selection to the media_player entity.

The Bang & Olufsen App allows users to create sound modes with identical names, which is problematic because Home Assistant only uses a string is used to determine selection, which makes it impossible to determine the selection of two identically named sound modes.

Therefore the unique ID of the sound mode has been appended to the sound mode's name in Home Assistant.
For example: the test sound mode is now called test - 100.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@epenet
Copy link
Contributor

epenet commented Jul 5, 2024

For example: the test sound mode is now called test - 100.

Would it not be prettier with brackets?
test (100)

@mj23000
Copy link
Contributor Author

mj23000 commented Jul 6, 2024

For example: the test sound mode is now called test - 100.

Would it not be prettier with brackets? test (100)

Yeah that looks better. Changed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants