Skip to content

update python-openzwave to 4.1.3#12057

Merged
todschmidt merged 2 commits intohome-assistant:devfrom
perosb:update-python-openzwave
Feb 3, 2018
Merged

update python-openzwave to 4.1.3#12057
todschmidt merged 2 commits intohome-assistant:devfrom
perosb:update-python-openzwave

Conversation

@perosb
Copy link
Copy Markdown
Contributor

@perosb perosb commented Jan 30, 2018

Description:

update python_openzwave to latest version.

Checklist:

  • The code change is tested and works locally.

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@dshokouhi
Copy link
Copy Markdown
Member

just an FYI but looks like we may be able to get a new zwave service for updating the configs :)

OpenZWave/python-openzwave#105 (comment)

@perosb
Copy link
Copy Markdown
Contributor Author

perosb commented Jan 30, 2018

@dshokouhi saw that too. Great if so.

Though is says it won't update for shared flavor which seem to be the default.
For now this is just a bump.

@todschmidt
Copy link
Copy Markdown
Contributor

Yeah, I saw that as well, and it would sort of work in that we could add something like a button in the front end zwave config to implement the update function. But as you say it won't work for shared and it also doesn't address how we handle upgrades.

@SebasT87
Copy link
Copy Markdown

According to the docs it defaults to shared, but only if there’s a precompliled OZW library available. On a normal HASS install there shouldn’t be any (my guess??) so it should revert to embed thus the update function should work

@perosb
Copy link
Copy Markdown
Contributor Author

perosb commented Jan 30, 2018

I did an other PR here #12060 which includes a service that invokes the update method.

edit: I can see that it downloads the file and updates the pyozw_config.version so surely it runs the method completely.

edit: It might require a restart of HASS to use the updates...?

@dshokouhi
Copy link
Copy Markdown
Member

FYI 0.4.3 was released yesterday :) seems like we may be getting more frequent or even automated releases now?

@perosb perosb changed the title update python-openzwave to 4.1.0 update python-openzwave to 4.1.3 Feb 2, 2018
@todschmidt
Copy link
Copy Markdown
Contributor

I don;t see any reason not to merge this, a lot of users have been looking for updated conifigs for quite a while. Thanks for adding this.

@pho
Copy link
Copy Markdown

pho commented Feb 12, 2018

This has been mistitled as 4.1.3 where it should be 0.4.3, isnt it?

Just pointing it out because I read about it on the latest release changelog, but saw a different version being installed on the logs

@perosb
Copy link
Copy Markdown
Contributor Author

perosb commented Feb 12, 2018

Yes. You are correct.

@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
@perosb perosb deleted the update-python-openzwave branch August 2, 2018 16:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants