Skip to content

Add type ignore comments#119052

Merged
cdce8p merged 1 commit into
home-assistant:devfrom
cdce8p:fix-mypy
Jun 7, 2024
Merged

Add type ignore comments#119052
cdce8p merged 1 commit into
home-assistant:devfrom
cdce8p:fix-mypy

Conversation

@cdce8p
Copy link
Copy Markdown
Member

@cdce8p cdce8p commented Jun 7, 2024

Proposed change

google-auth version 2.30.0 was released today. In contrast to 2.29.0 it now includes a py.typed file. However, not everything is typed. In particular Credentials is missing annotations which cause the no-untyped-call errors seen in CI runs.

https://github.com/googleapis/google-auth-library-python/releases/tag/v2.30.0
https://github.com/googleapis/google-auth-library-python/blob/v2.30.0/google/oauth2/credentials.py#L71
https://github.com/googleapis/google-auth-library-python/blob/v2.30.0/google/oauth2/py.typed

https://github.com/home-assistant/core/actions/runs/9412320306/job/25927027688?pr=118452
https://github.com/home-assistant/core/actions/runs/9410378973/job/25921957833
https://github.com/home-assistant/core/actions/runs/9414463462/job/25933478159

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jun 7, 2024

Hey there @tkdrob, mind taking a look at this pull request as it has been labeled with an integration (google_sheets) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of google_sheets can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign google_sheets Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jun 7, 2024

Hey there @allenporter, mind taking a look at this pull request as it has been labeled with an integration (nest) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of nest can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign nest Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jun 7, 2024

Hey there @tronikos, mind taking a look at this pull request as it has been labeled with an integration (google_assistant_sdk) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of google_assistant_sdk can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign google_assistant_sdk Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@cdce8p cdce8p merged commit af65da3 into home-assistant:dev Jun 7, 2024
@cdce8p cdce8p deleted the fix-mypy branch June 7, 2024 09:13
frenck pushed a commit that referenced this pull request Jun 7, 2024
@frenck frenck mentioned this pull request Jun 7, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cherry-picked cla-signed code-quality small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants