Skip to content

Fix KNX climate.set_hvac_mode not turning on#119012

Merged
marvin-w merged 1 commit into
devfrom
knx-fix-climate-turn_on
Jun 6, 2024
Merged

Fix KNX climate.set_hvac_mode not turning on#119012
marvin-w merged 1 commit into
devfrom
knx-fix-climate-turn_on

Conversation

@farmio
Copy link
Copy Markdown
Member

@farmio farmio commented Jun 6, 2024

Proposed change

UI doesn't seem to support independent climate.turn_on and climate.set_hvac_mode.
So - if both, a mode and on_off addresses are configured - we now always set the mode and turn on/off when climate.set_hvac_mode is called, not only set the mode. This means a off climate entity can't be switched from heat to cool and vice versa by a climate service (if needed it can be done by sending to the heat_cool address manually eg. with knx.send in an automation).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jun 6, 2024

Hey there @Julius2342, @marvin-w, mind taking a look at this pull request as it has been labeled with an integration (knx) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of knx can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign knx Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Copy Markdown
Contributor

@marvin-w marvin-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good :)

@marvin-w marvin-w merged commit a7429e5 into dev Jun 6, 2024
@marvin-w marvin-w deleted the knx-fix-climate-turn_on branch June 6, 2024 20:40
frenck pushed a commit that referenced this pull request Jun 7, 2024
@frenck frenck mentioned this pull request Jun 7, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KNX Climate (Thermostat) Not Working Properly On 2024.6.0

3 participants