Skip to content

Fix unit of measurement for airgradient sensor#118981

Merged
frenck merged 2 commits into
home-assistant:devfrom
joostlek:ag-uom
Jun 7, 2024
Merged

Fix unit of measurement for airgradient sensor#118981
frenck merged 2 commits into
home-assistant:devfrom
joostlek:ag-uom

Conversation

@joostlek
Copy link
Copy Markdown
Member

@joostlek joostlek commented Jun 6, 2024

Proposed change

Fix unit of measurement for airgradient sensor

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jun 6, 2024

Hey there @airgradienthq, mind taking a look at this pull request as it has been labeled with an integration (airgradient) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of airgradient can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign airgradient Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@joostlek joostlek marked this pull request as draft June 6, 2024 15:13
@joostlek joostlek marked this pull request as ready for review June 7, 2024 07:09
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @joostlek 👍

../Frenck

@frenck frenck merged commit 6027af3 into home-assistant:dev Jun 7, 2024
@joostlek joostlek deleted the ag-uom branch June 7, 2024 07:19
@frenck frenck mentioned this pull request Jun 7, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AirGradient PM0.3 count value is unitless

2 participants