Skip to content

Check if imap message text has a value instead of checking if its not None#118901

Merged
jbouwh merged 3 commits into
home-assistant:devfrom
engrbm87:imap-content-fix
Jun 6, 2024
Merged

Check if imap message text has a value instead of checking if its not None#118901
jbouwh merged 3 commits into
home-assistant:devfrom
engrbm87:imap-content-fix

Conversation

@engrbm87
Copy link
Copy Markdown
Contributor

@engrbm87 engrbm87 commented Jun 5, 2024

Proposed change

There are cases when message_text value is an empty string instead of None where the email body is in fact html. Its better to check these variables have any value instead of checking if they are None.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jun 5, 2024

Hey there @jbouwh, mind taking a look at this pull request as it has been labeled with an integration (imap) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of imap can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign imap Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@jbouwh
Copy link
Copy Markdown
Contributor

jbouwh commented Jun 5, 2024

Should we trim when we check?

@engrbm87
Copy link
Copy Markdown
Contributor Author

engrbm87 commented Jun 6, 2024

Should we trim when we check?

I didn't notice any spaces in my testing but I think its a good idea

@engrbm87 engrbm87 force-pushed the imap-content-fix branch from ec030ba to 1abe4d7 Compare June 6, 2024 04:39
@jbouwh
Copy link
Copy Markdown
Contributor

jbouwh commented Jun 6, 2024

Do you think you can add a test payload and a test for this?

@engrbm87
Copy link
Copy Markdown
Contributor Author

engrbm87 commented Jun 6, 2024

Do you think you can add a test payload and a test for this?

I gave it a shot. Hopefully, I added the test correctly.

Copy link
Copy Markdown
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thanks @engrbm87 👍

@jbouwh jbouwh added this to the 2024.6.1 milestone Jun 6, 2024
@jbouwh jbouwh merged commit cab58fa into home-assistant:dev Jun 6, 2024
@engrbm87 engrbm87 deleted the imap-content-fix branch June 6, 2024 13:31
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants