Skip to content

Prioritize literal text with name slots in sentence matching#118900

Merged
balloob merged 1 commit into
devfrom
synesthesiam-20240605-sentence-prioritization
Jun 6, 2024
Merged

Prioritize literal text with name slots in sentence matching#118900
balloob merged 1 commit into
devfrom
synesthesiam-20240605-sentence-prioritization

Conversation

@synesthesiam
Copy link
Copy Markdown
Contributor

Proposed change

When matching wildcards, Assist prefers sentence matches that have more "literal" text in them (hard-coded words from the original sentence template). Sentences with a name slot (targeting a specific entity) are further prioritized, but the same sorting based on literal text was not being applied.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jun 5, 2024

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (conversation) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of conversation can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign conversation Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@synesthesiam synesthesiam added this to the 2024.6.1 milestone Jun 5, 2024
@balloob balloob merged commit bca8958 into dev Jun 6, 2024
@balloob balloob deleted the synesthesiam-20240605-sentence-prioritization branch June 6, 2024 18:20
frenck pushed a commit that referenced this pull request Jun 7, 2024
@frenck frenck mentioned this pull request Jun 7, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants