Skip to content

Handle Daikin AC adapters without fan mode and swing mode support#11840

Merged
pvizeli merged 2 commits into
home-assistant:devfrom
rofrantz:Handle-daikin-without-fan-mode-and-swing-mode-support
Jan 24, 2018
Merged

Handle Daikin AC adapters without fan mode and swing mode support#11840
pvizeli merged 2 commits into
home-assistant:devfrom
rofrantz:Handle-daikin-without-fan-mode-and-swing-mode-support

Conversation

@rofrantz
Copy link
Copy Markdown
Contributor

@rofrantz rofrantz commented Jan 20, 2018

Description:

Based on https://community.home-assistant.io/t/daikin-component-no-climate-entities-created-task-exception/39608 there are users with Daikin climate devices with BRP072A42 adapters witch do not support changing the fan speed (FAN_MODE) or fan direction (SWING_MODE). This PR should fix that issue.

Related issue (if applicable): fixes https://community.home-assistant.io/t/daikin-component-no-climate-entities-created-task-exception/39608

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#4482

Checklist:

  • The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@rofrantz rofrantz changed the title Handle daikin without fan mode and swing mode support Handle Daikin AC without fan mode and swing mode support Jan 20, 2018
@rofrantz rofrantz changed the title Handle Daikin AC without fan mode and swing mode support Handle Daikin AC adapters without fan mode and swing mode support Jan 21, 2018
@pvizeli
Copy link
Copy Markdown
Member

pvizeli commented Jan 24, 2018

Maybe a future change: set and get is to generic for that what he do.

@pvizeli pvizeli merged commit b43b542 into home-assistant:dev Jan 24, 2018
@rofrantz
Copy link
Copy Markdown
Contributor Author

U mean to split those multiple if's into their dedicated functions @pvizeli ?
If yes, I'll try to move them in a future PR

@balloob balloob mentioned this pull request Jan 26, 2018
@fredrike
Copy link
Copy Markdown
Contributor

Hi @rofrantz!

I have the BRP072A42 WiFi adapter and my AC unit do support both fan and swing mode. What I mean is that it is not dependant on the WiFi adapter but on the unit the adapter is connected to. As far as I understand is the difference between adapters just the included cables in the package the actual WiFi adapter is the same (but for different AC units you need different cables). The features of the adapter is limited by the AC unit not the other way around. (But I don't have references on this.)

It's great that you keep improving the the support for Daikin but I'm still running one of the first versions you released based on the fact that I don't really like the unsorted settings list below compared to the previous one.

screen shot 2018-01-29 at 9 15 41
.

@MartinHjelmare
Copy link
Copy Markdown
Member

Please open an issue if there's a problem. We don't like to have the discussion in merged PRs.

@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants