Skip to content

Add shared notify service migration repair helper#117213

Merged
MartinHjelmare merged 6 commits into
devfrom
notify-migration-repair-helper
May 11, 2024
Merged

Add shared notify service migration repair helper#117213
MartinHjelmare merged 6 commits into
devfrom
notify-migration-repair-helper

Conversation

@jbouwh
Copy link
Copy Markdown
Contributor

@jbouwh jbouwh commented May 10, 2024 •
edited by MartinHjelmare
Loading

Proposed change

Create a shared helper for registering a fixable repair issue that is used to instruct users to update their automations to use the new notify entity services.

Other integrations implementing the legacy notify service are likely to migrate and can use this new helper to save time.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented May 10, 2024

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (notify) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of notify can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign notify Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented May 10, 2024

Hey there @Julius2342, @farmio, @marvin-w, mind taking a look at this pull request as it has been labeled with an integration (knx) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of knx can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign knx Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@jbouwh jbouwh force-pushed the notify-migration-repair-helper branch from 089c7ee to 3202da8 Compare May 10, 2024 23:06
@jbouwh jbouwh force-pushed the notify-migration-repair-helper branch from 3202da8 to 545edb2 Compare May 10, 2024 23:14
@jbouwh jbouwh marked this pull request as ready for review May 10, 2024 23:15
@jbouwh jbouwh requested review from a team, farmio and marvin-w as code owners May 10, 2024 23:15
@jbouwh jbouwh mentioned this pull request May 10, 2024
Merged
20 tasks
MartinHjelmare
MartinHjelmare requested changes May 11, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are failing.

Comment thread homeassistant/components/notify/manifest.json Outdated
@home-assistant home-assistant Bot marked this pull request as draft May 11, 2024 06:53
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented May 11, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@MartinHjelmare MartinHjelmare changed the title Add shared notifiy service migration repair helper Add shared notify service migration repair helper May 11, 2024
MartinHjelmare
MartinHjelmare reviewed May 11, 2024
View reviewed changes
Comment thread homeassistant/components/homematic/manifest.json Outdated
Comment thread tests/components/homematic/test_notify.py Outdated
@jbouwh jbouwh marked this pull request as ready for review May 11, 2024 14:38
@jbouwh jbouwh requested review from fabaff and pvizeli as code owners May 11, 2024 14:38
@home-assistant home-assistant Bot requested a review from MartinHjelmare May 11, 2024 14:38
MartinHjelmare
MartinHjelmare approved these changes May 11, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 7eb8f26 into dev May 11, 2024
@MartinHjelmare MartinHjelmare deleted the notify-migration-repair-helper branch May 11, 2024 19:13
dgomes pushed a commit to dgomes/home-assistant that referenced this pull request May 11, 2024
@jbouwh @dgomes
Add shared notify service migration repair helper (home-assistant#117213
8661135 
)

* Add shared notifiy service migration repair helper

* Delete ecobee repairs.py

* Update dependency

* Fix file test

* Fix homematic tests

* Improve tests for file  and homematic
@github-actions github-actions Bot locked and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@farmio farmio Awaiting requested review from farmio farmio is a code owner

@marvin-w marvin-w Awaiting requested review from marvin-w marvin-w is a code owner

@pvizeli pvizeli Awaiting requested review from pvizeli pvizeli is a code owner

@fabaff fabaff Awaiting requested review from fabaff fabaff is a code owner

Assignees

@marvin-w marvin-w

@farmio farmio

Labels

cla-signed code-quality core has-tests integration: ecobee integration: knx integration: notify Quality Scale: internal Quality Scale: No score Quality Scale: platinum

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jbouwh @MartinHjelmare @marvin-w @farmio