Skip to content

Mold_indicator.py fixed not to include spaces or dots in attribute names #11694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Danielhiversen merged 1 commit into from
Jan 16, 2018
Merged

Mold_indicator.py fixed not to include spaces or dots in attribute names #11694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion homeassistant/components/sensor/mold_indicator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

_LOGGER = logging.getLogger(__name__)

ATTR_CRITICAL_TEMP = 'Est. Crit. Temp'
ATTR_CRITICAL_TEMP = 'EstimatedCriticalTemp'
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare Jan 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attributes should be lowercase snakecase.

Copy link
Copy Markdown
Contributor

@Mariusthvdb Mariusthvdb Jan 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes indeed please. Change EstimatedCriticalTemp in estimated_critical_temp

is this updated now, and do we need to change anything in the HA setup?
just using platform: most_indicator as is.
No need to put mold_indicator.py in custom_components ?

Cheers,
Marius

ATTR_DEWPOINT = 'Dewpoint'

CONF_CALIBRATION_FACTOR = 'calibration_factor'
Expand Down