Skip to content

Added extra arguments to onvif platform config#11680

Merged
fabaff merged 1 commit into
home-assistant:devfrom
karlkar:onvif_args_dev
Jan 16, 2018
Merged

Added extra arguments to onvif platform config#11680
fabaff merged 1 commit into
home-assistant:devfrom
karlkar:onvif_args_dev

Conversation

@karlkar
Copy link
Copy Markdown
Contributor

@karlkar karlkar commented Jan 15, 2018

Description:

FFMPEG platform allows to set additional parameters in the config. ONVIF platform didn't allow that until this CL. There were always arguments provided by author of onvif platform plugin '-q:v 2'. Somebody may want to use another arguments, like '-pred 1 -q:v 10'.

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#4425

Example entry for configuration.yaml (if applicable):

camera:
  - platform: onvif
    host: 192.168.1.10
    extra_arguments: -pred 1 -q:v 2

Checklist:

  • The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🐦

@fabaff fabaff merged commit 9869252 into home-assistant:dev Jan 16, 2018
@balloob balloob mentioned this pull request Jan 26, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants