Skip to content

Fix zha color probe#11670

Merged
balloob merged 1 commit into
home-assistant:devfrom
rcloran:zha-color-fix
Jan 15, 2018
Merged

Fix zha color probe#11670
balloob merged 1 commit into
home-assistant:devfrom
rcloran:zha-color-fix

Conversation

@rcloran
Copy link
Copy Markdown
Contributor

@rcloran rcloran commented Jan 15, 2018

Description:

#11522 assumed that the light_color attribute always existed. This fixes that assumption.

#9232 read in such a way that during initialization, a ZigBee delivery error exception would be printed to the log. This fixes that.

In #10495 safe_read was copied from components/light/zha.py. This puts it in a more central location, since it should be useful to any component using zha.

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@balloob
Copy link
Copy Markdown
Member

balloob commented Jan 15, 2018

Thanks for the quick fix! 🌮

@balloob balloob merged commit ff32f90 into home-assistant:dev Jan 15, 2018
@rcloran rcloran deleted the zha-color-fix branch January 16, 2018 00:16
balloob pushed a commit that referenced this pull request Jan 16, 2018
@balloob balloob mentioned this pull request Jan 16, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
@ghost ghost removed the platform: light.zha label Mar 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants