Skip to content

light/mqqt_json: allow brightness scaling#11613

Merged
fabaff merged 1 commit into
home-assistant:devfrom
jkoelker:light_mqtt_json_bright_scale
Jan 13, 2018
Merged

light/mqqt_json: allow brightness scaling#11613
fabaff merged 1 commit into
home-assistant:devfrom
jkoelker:light_mqtt_json_bright_scale

Conversation

@jkoelker
Copy link
Copy Markdown
Contributor

@jkoelker jkoelker commented Jan 13, 2018

Description:

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#4403

Example entry for configuration.yaml (if applicable):

light:
  platform: mqtt_json
  name: test
  state_topic: "mqtt_json_light_1"
  command_topic: "mqtt_json_light_1/set"
  brightness: true
  brightness_scale: 4095

Checklist:

  • The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @jkoelker,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@jkoelker jkoelker force-pushed the light_mqtt_json_bright_scale branch from 1a02ad7 to fc24a30 Compare January 13, 2018 00:26
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🐦

@fabaff fabaff merged commit 2e08766 into home-assistant:dev Jan 13, 2018
@balloob balloob mentioned this pull request Jan 26, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants