small sonos cleanup#11607
Merged
Merged
Conversation
amelchio
approved these changes
Jan 13, 2018
Contributor
amelchio
left a comment
amelchio
left a comment
There was a problem hiding this comment.
This is okay but please consider refraining from a large refactoring until my own sonos rework to push is hopefully merged (I am still pushing for the necessary SoCo changes).
|
|
||
| @soco_error | ||
| @soco_filter_upnperror(UPNP_ERRORS_TO_IGNORE) | ||
| @soco_error(UPNP_ERRORS_TO_IGNORE) |
Contributor
There was a problem hiding this comment.
Just a comment: the constant UNPN_ERRORS_TO_IGNORE probably has a too generic name since it apparently only applies to some operations.
Member
Author
|
@amelchio I'm fine with close this if you add it into your PR |
Contributor
|
You can merge this, it should not conflict. I will integrate all recent sonos changes before re-opening my PR. |
Merged
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Small code cleanup with error handling