Skip to content

Bump python-fritzhome to 0.6.11 #115904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edenhaus merged 3 commits into from
Apr 23, 2024
+18 −14
Merged

Bump python-fritzhome to 0.6.11 #115904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
259c980
bump pyfritzhome to 0.6.11
mib1185 Apr 20, 2024
7ca88ed
enable new cache cleanup feature in lib
mib1185 Apr 20, 2024
807b8b3
make call to cleanup_removed_devices thread-safe
mib1185 Apr 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions homeassistant/components/fritzbox/coordinator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,9 @@ def cleanup_removed_devices(self, avaiable_ains: list[str]) -> None:
def _update_fritz_devices(self) -> FritzboxCoordinatorData:
"""Update all fritzbox device data."""
try:
self.fritz.update_devices()
self.fritz.update_devices(ignore_removed=False)
if self.has_templates:
self.fritz.update_templates()
self.fritz.update_templates(ignore_removed=False)
except RequestConnectionError as ex:
raise UpdateFailed from ex
except HTTPError:
Expand All @@ -93,9 +93,9 @@ def _update_fritz_devices(self) -> FritzboxCoordinatorData:
self.fritz.login()
except LoginError as ex:
raise ConfigEntryAuthFailed from ex
self.fritz.update_devices()
self.fritz.update_devices(ignore_removed=False)
if self.has_templates:
self.fritz.update_templates()
self.fritz.update_templates(ignore_removed=False)

devices = self.fritz.get_devices()
device_data = {}
Expand Down Expand Up @@ -124,14 +124,18 @@ def _update_fritz_devices(self) -> FritzboxCoordinatorData:
self.new_devices = device_data.keys() - self.data.devices.keys()
self.new_templates = template_data.keys() - self.data.templates.keys()

if (
self.data.devices.keys() - device_data.keys()
or self.data.templates.keys() - template_data.keys()
):
self.cleanup_removed_devices(list(device_data) + list(template_data))

return FritzboxCoordinatorData(devices=device_data, templates=template_data)

async def _async_update_data(self) -> FritzboxCoordinatorData:
"""Fetch all device data."""
return await self.hass.async_add_executor_job(self._update_fritz_devices)
new_data = await self.hass.async_add_executor_job(self._update_fritz_devices)

if (
self.data.devices.keys() - new_data.devices.keys()
or self.data.templates.keys() - new_data.templates.keys()
):
self.cleanup_removed_devices(
list(new_data.devices) + list(new_data.templates)
)

return new_data
2 changes: 1 addition & 1 deletion homeassistant/components/fritzbox/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"iot_class": "local_polling",
"loggers": ["pyfritzhome"],
"quality_scale": "gold",
"requirements": ["pyfritzhome==0.6.10"],
"requirements": ["pyfritzhome==0.6.11"],
"ssdp": [
{
"st": "urn:schemas-upnp-org:device:fritzbox:1"
Expand Down
2 changes: 1 addition & 1 deletion requirements_all.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1833,7 +1833,7 @@ pyforked-daapd==0.1.14
pyfreedompro==1.1.0

# homeassistant.components.fritzbox
pyfritzhome==0.6.10
pyfritzhome==0.6.11

# homeassistant.components.ifttt
pyfttt==0.3
Expand Down
2 changes: 1 addition & 1 deletion requirements_test_all.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1429,7 +1429,7 @@ pyforked-daapd==0.1.14
pyfreedompro==1.1.0

# homeassistant.components.fritzbox
pyfritzhome==0.6.10
pyfritzhome==0.6.11

# homeassistant.components.ifttt
pyfttt==0.3
Expand Down