Skip to content

Fix new squeezebox service descriptions for lazy loading#11574

Merged
amelchio merged 1 commit into
home-assistant:devfrom
amelchio:squeezebox-lazy-loading-descriptions
Jan 11, 2018
Merged

Fix new squeezebox service descriptions for lazy loading#11574
amelchio merged 1 commit into
home-assistant:devfrom
amelchio:squeezebox-lazy-loading-descriptions

Conversation

@amelchio
Copy link
Copy Markdown
Contributor

Description:

It seems that #10969 was merged without being updated for #11479. This should fix it.

Related issue (if applicable): fixes #11569

Checklist:

  • The code change is tested and works locally.

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully.
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can be merged when tests pass.

@amelchio amelchio merged commit 5fda78c into home-assistant:dev Jan 11, 2018
@emlove
Copy link
Copy Markdown
Contributor

emlove commented Jan 11, 2018

Thanks for the quick fix! Sorry about that!

@balloob balloob mentioned this pull request Jan 11, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error while setting up platform squeezebox (0.60-DEV)

4 participants